Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)
ClosedPublic

Authored by kossebau on Sep 1 2019, 1:34 PM.

Details

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Sep 1 2019, 1:34 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 1 2019, 1:34 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
kossebau requested review of this revision.Sep 1 2019, 1:34 PM
kossebau added inline comments.Sep 1 2019, 1:35 PM
src/view/kateviewhelpers.cpp
1191 ↗(On Diff #65125)

Refactoring to one static object will be separate commit.

cullmann accepted this revision.Sep 1 2019, 4:52 PM
cullmann added a subscriber: cullmann.

ok

src/view/kateviewhelpers.cpp
1191 ↗(On Diff #65125)

I would have no issue with this to be in this commit ;=)
That saves me review time :P

This revision is now accepted and ready to land.Sep 1 2019, 4:52 PM
This revision was automatically updated to reflect the committed changes.