Move planet feed reader to Feed class
- Maniphest Tasks
- T11299: Move Capacity websites and kde.org to PHP7
Not tested yet
Aside from the comments above, this looks fine.
Are all other parts of the codebase good to go from the perspective of PHP7? (including the Paypal donations stuff?)
|21 ↗||(On Diff #65182)|
Just curious, what is this trying to do?
We already make sure that the path containing the files with the credentials is in the PHP include_path (as part of the general server setup) so no explicit code for that is needed.
|24 ↗||(On Diff #65182)|
We should probably use UTC for this.
One of the current outstanding issues with the KDE.org site is that it uses not one or two, but three different configuration files for the same database details.
These probably need to be unified.
The current content of donations_auth.inc is as follows:
<?php $host = "localhost"; $db = "kdeorg"; $user = "kdeorg"; $pass = "<removed>"; $sq = mysql_connect($host,$user,$pass); mysql_select_db($db); mysql_set_charset('utf8', $sq); ?>
The contents of db_auth.inc is as follows:
<?php $db_username = "kdeorg"; $db_password = "<removed>"; $db_database = "kdeorg"; ?>
and finally, the contents of config.php is as follows:
<?php $currency = 'EUR'; $kdeEvMail = "email@example.com"; $dbhost = '<removed'; $dbuser = 'kdeorg'; $dbpass = '<removed>'; $dbname = 'kdeorg'; $dbConnection = mysqli_connect($dbhost, $dbuser, $dbpass, $dbname) or die (mysqli_connect_error()); ?>
There was so many error/warning in community/donations/graph.php that I decided to rewrite it using graph.js
I tested the paypal code using the sandbox and it works :)
- remove all the notify.php
- Unify the database access to the following config.php located in capacity/includes:
<?php $currency = 'EUR'; $kdeEvMail = "firstname.lastname@example.org"; $dbhost = 'localhost'; $dbuser = 'kdeorg'; $dbpass = ''; $dbname = 'kdeorg'; $dbConnection = new PDO('mysql:host=' . $dbhost . ';dbname=' . $dbname, $dbuser, $dbpass);
- Write fixtures for all the donation compaign for testing purpose disabled by default (see setup-db.php)
- Fix the error I just found ;)
query not used
I forgot execute()
|5 ↗||(On Diff #66509)|
Affero isn't really one of our "approved" licenses https://community.kde.org/Policies/Licensing_Policy
|59 ↗||(On Diff #66509)|
you left the sandbox here
|69 ↗||(On Diff #66509)|
is there anything this is waiting on? otherwise i'd just commit it and be aware thing changed in case something breaks and fix it fast
do we need this?
i think we're always running in debug (double check with ben, so no need to have these error_log calls?)
this doesn't seem like an error