Differential D23638

Fix build with cmake < 3.7
ClosedPublic
Actions

Authored by wbauer on Sep 1 2019, 11:45 AM.

Details

Reviewers
aacid
Group Reviewers
Rocs
Commits
R73:a698894fdaac: Fix build with cmake < 3.7
Summary

VERSION_GREATER_EQUAL was introduced in cmake 3.7, but the specified minimum version is 3.3.
So use NOT VERSION_LESS instead to still support older cmake versions too.

Test Plan

rocs master builds fine with cmake 3.5.2 now, and also newer versions (haven't tried older versions).

Before, I got this error when using cmake 3.5.2:

CMake Error at CMakeLists.txt:85 (if):
  if given arguments:

    "KF5Declarative_VERSION" "VERSION_GREATER_EQUAL" "5.45"

  Unknown arguments specified

Diff Detail

Repository
R73 Rocs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer created this revision.Sep 1 2019, 11:45 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 1 2019, 11:45 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wbauer requested review of this revision.Sep 1 2019, 11:45 AM
wbauer edited the summary of this revision. (Show Details)Sep 1 2019, 12:17 PM
aacid accepted this revision.Sep 1 2019, 5:41 PM
This revision is now accepted and ready to land.Sep 1 2019, 5:41 PM
Closed by commit R73:a698894fdaac: Fix build with cmake < 3.7 (authored by wbauer). · Explain WhySep 1 2019, 6:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 65167

View Options

CMakeLists.txt

Loading...