Use QChar overload for single char strings where possible
ClosedPublic

Authored by kossebau on Sep 1 2019, 10:38 AM.

Details

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Sep 1 2019, 10:38 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 1 2019, 10:38 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
kossebau requested review of this revision.Sep 1 2019, 10:38 AM
cullmann accepted this revision.Sep 1 2019, 3:15 PM
cullmann added a subscriber: cullmann.

Looks ok, too.
Thanks!

This revision is now accepted and ready to land.Sep 1 2019, 3:15 PM
This revision was automatically updated to reflect the committed changes.

Do you have a clang-tidy plugin for such changes, or do you use a manual regexp for detection?

Do you have a clang-tidy plugin for such changes, or do you use a manual regexp for detection?

Very unprofessionally I use the grep dialog of KDevelop, to collect hits of method names, and then iterate over the search result and check with type tooltip over the class if this is one of the class & methods I know the min API and how it can be improvded. Dull work, but possibly serves me the purpose where others play ballerspiele, though for me there is at least some little long-term effect ;) If the world and I were perfect, I would rather write proper clazy/clang-tidy plugins. but there is no promise on quick success... ;)

:=) If you have time to spare and some fun for tedious work: D19367

Finalizing a chunk wise regex search as drafted in https://cgit.kde.org/ktexteditor.git/commit/?id=dbebf059575f83608c941111ac3a6d374667b5a6 is highly appreciated ;=)