[kicker/kickoff] Use discover icon for manage application action
AbandonedPublic

Authored by nicolasfella on Aug 31 2019, 11:24 PM.

Details

Summary

While not 100% technically correct since another app might be associated with appstream URLs it's still much more expressive than the current icon

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Aug 31 2019, 11:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 31 2019, 11:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Aug 31 2019, 11:24 PM
nicolasfella edited the test plan for this revision. (Show Details)Aug 31 2019, 11:25 PM
ngraham accepted this revision.Sep 1 2019, 12:28 AM

Definitely better.

This revision is now accepted and ready to land.Sep 1 2019, 12:28 AM
This revision was automatically updated to reflect the committed changes.
hein reopened this revision.Sep 4 2019, 12:37 AM

Distros can change the package manager to be run, so hard-coding the icon is wrong. It should be looked up from the configured application.

This revision is now accepted and ready to land.Sep 4 2019, 12:37 AM
hein requested changes to this revision.Sep 4 2019, 12:37 AM
This revision now requires changes to proceed.Sep 4 2019, 12:37 AM
In D23623#525410, @hein wrote:

Distros can change the package manager to be run, so hard-coding the icon is wrong. It should be looked up from the configured application.

That makes sense, yeah.

nicolasfella abandoned this revision.Sep 6 2019, 1:58 PM