[kicker/kickoff] Use better icon for edit application
AbandonedPublic

Authored by nicolasfella on Aug 31 2019, 11:17 PM.

Details

Reviewers
hein
ngraham
Group Reviewers
Plasma
Summary

As the TODO comment suggests the old one is not very good here

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
editicon
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15918
Build 15936: arc lint + arc unit
nicolasfella created this revision.Aug 31 2019, 11:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 31 2019, 11:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Aug 31 2019, 11:17 PM
nicolasfella edited the test plan for this revision. (Show Details)Aug 31 2019, 11:18 PM

While we're at it, I think the text could be improved too. "Edit Application", when read literally (as an average user is likely to do) implies that this actually alters the app itself, which is not accurate.

What do you suggest?

Since this action actually opens the properties window (which just happens to have a tab that allows you to edit the .desktop file), how about just, "Properties". Then we could use the standard document-properties icon.

nicolasfella abandoned this revision.May 18 2020, 3:52 PM