Differential D2362

Trying to fix my bad Move Tool patch.
ClosedPublic
Actions

Authored by tantsevov on Aug 6 2016, 11:32 AM.

Details

Reviewers
woltherav
Group Reviewers
Krita
Commits
R37:92c253ac0ac1: Trying to fix my bad Move Tool patch.
Summary

Revised method implementation MoveDiskrete. It turned out that the ending is lost when trying repetition. Added blocking signals from the spinners.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tantsevov updated this revision to Diff 5704.Aug 6 2016, 11:32 AM
tantsevov retitled this revision from to Trying to fix my bad Move Tool patch..
tantsevov updated this object.
tantsevov edited the test plan for this revision. (Show Details)
tantsevov added a reviewer: Krita.
tantsevov added a project: Krita.
tantsevov added subscribers: dkazakov, rempt, woltherav.
woltherav added a comment.Aug 6 2016, 1:13 PM

Okay, gonna test today :3

woltherav accepted this revision.Aug 8 2016, 10:48 AM
woltherav added a reviewer: woltherav.

Okay, I have been testing this all weekend, and it seems to prevent the crash successfully.

This revision is now accepted and ready to land.Aug 8 2016, 10:48 AM
Closed by commit R37:92c253ac0ac1: Trying to fix my bad Move Tool patch. (authored by tantsevov, committed by dkazakov). · Explain WhyAug 10 2016, 7:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5783

View Options

plugins/tools/basictools/kis_tool_move.cc

Loading...