Get rid of deprecated QSignalMapper
ClosedPublic

Authored by yurchor on Aug 31 2019, 7:32 PM.

Details

Summary

QSignalMapper class is obsolete. This patch replaces its occurrences with lambdas. Qt version upgrade to 5.6 is needed because addAction overload has been added in Qt 5.6

Test Plan
  1. Start User Menu editor with "LaTeX -> Edit User Menu". Try to add some items using popup menu.
  2. Create a project and use sidebar popup menu to handle its components.
  3. Open some structured document and use the "Structure" panel to manage the structure items.

Diff Detail

Repository
R468 Kile
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15906
Build 15924: arc lint + arc unit
yurchor created this revision.Aug 31 2019, 7:32 PM
Restricted Application added a project: Kile. · View Herald TranscriptAug 31 2019, 7:32 PM
yurchor requested review of this revision.Aug 31 2019, 7:32 PM
mludwig added inline comments.Sep 21 2019, 10:08 AM
src/dialogs/usermenu/usermenutree.cpp
179

Do you think you can get rid of 'slotPopupActivated' as well? and also of the other helper slots below?

yurchor updated this revision to Diff 66587.Sep 21 2019, 1:08 PM

Replace the helper slots with oneliners where appropriate

mludwig accepted this revision.Sep 22 2019, 2:23 PM

Looks good - thanks a lot!

This revision is now accepted and ready to land.Sep 22 2019, 2:23 PM
This revision was automatically updated to reflect the committed changes.