| zzag | |
| anthonyfieroni | |
| romangg |
| KWin |
Firstly, it was completely broken, no-one called registerObject.
Secondly deleting the adaptor doesn't really make sense, you'd still
leave the object valid, only have it broken. Docs of
QDBusAbstractAdaptor do say not to ever delete it manually.
Thirdly we don't need Q_CLASSINFO setting the DBus interface on the
exported item when we use an adaptor.
Manually added some setEnabled/disabled
Could now see the path
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Secondly deleting the adaptor doesn't really make sense, you'd still leave the object valid, only have it broken.
Why is that the case? (I'm a QDBus noob)
According to QDBusAbstractAdaptor documentation this change makes sense.
However can you please explain why the adaptor won't be removed if you delete it?
| orientation_sensor.h | ||
|---|---|---|
| 29 | Delete it. | |
To be honest I don't think it's sensible trying to fix this instead of deactivating. The next problem can be just around the corner. And then we need to again have a lengthy bug hunt. To find the reason for this issue I needed at least 6 hours (ok, that was probably an outlier). The orientation sensor architecture is broken and is at best not functional and at worst hinders our other developments.
Since you have now spend the time already I won't nack it, but we can use your precious development time on other actual usable features much more Dave.
However can you please explain why the adaptor won't be removed if you delete it?
Assuming the question is "why the interface won't be removed if you remove the adaptor"?
Qt builds the object introspection when you register the object.
From a DBus POV, it is possible to do this at runtime, just not in Qt - but in either case it's slightly easier to tell if an object is available on a path than for a client and has a specific interface.
As for the crash, QDBusAdaptorConnector::addAdaptor doesn't handle the matching removal, because it'd be supporting something that wouldn't work anyway. I didn't spend too much time looking after this point.