Quick tile only resizeable clients
ClosedPublic

Authored by zzag on Aug 31 2019, 12:35 PM.

Details

Reviewers
None
Group Reviewers
KWin
Commits
R108:2963c9ca56a0: Quick tile only resizeable clients
Summary

Maximized clients weren't considered as resizeable when quick tiling was
added. Therefore, a special case was added in Client::setQuickTileMode().
However, that special case didn't take into account that a fullscreen
client can be also maximized. Clearly, we don't want users quick tile
fullscreen clients.

BUG: 411028
FIXED-IN: 5.17.0

Test Plan

No longer able to quick tile maximized fullscreen window of Konsole.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 31 2019, 12:35 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 31 2019, 12:35 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 31 2019, 12:35 PM
romangg added a subscriber: romangg.EditedAug 31 2019, 1:14 PM

Is for a maximized client nowadays isResizable() true if it's a resizable client in general?

EDIT: It's possible to resize a maximized client with Alt + right mouse button. So I think yes.

zzag added a comment.Aug 31 2019, 1:15 PM

Is for a maximized client nowadays isResizable() true if it's a resizable client in general?

EDIT: It's possible to resize a maximized client with Alt + right mouse button. So I think yes.

Yes, fullscreen clients is an exception though.

zzag added a comment.Sep 5 2019, 7:37 AM

Given that I have received only a question about resizeability of clients and no actual ack or nack, I assume that no one else from KWin can review such patches at the moment. Therefore, I'll land this revision.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 5 2019, 7:37 AM
This revision was automatically updated to reflect the committed changes.