Differential D23595

Speed up sending request to ksysguardd
ClosedPublic
Actions

Authored by jpalecek on Aug 31 2019, 2:22 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R111:2791a0c71f24: Speed up sending request to ksysguardd
Summary

While investigating bug 407526, I discovered that most of the time is spent in SensorAgent::sendRequest. This is because it searches the whole queue lineraly, which could take a lot of time if there's a lot of requests. This patch speeds it up by using a QSet of outstanding requests, obviating the need to search the queues.

Part of T11473: #407526: plasma + ksysguardd causing high cpu load

Diff Detail

Repository
R111 KSysguard Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jpalecek created this revision.Aug 31 2019, 2:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 31 2019, 2:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jpalecek requested review of this revision.Aug 31 2019, 2:22 AM
davidedmundson accepted this revision.Sep 2 2019, 10:27 PM
This revision is now accepted and ready to land.Sep 2 2019, 10:27 PM
Closed by commit R111:2791a0c71f24: Speed up sending request to ksysguardd (authored by jpalecek, committed by davidedmundson). · Explain WhyDec 9 2019, 5:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mksgrd/SensorAgent.h (11 lines)
Mksgrd/SensorAgent.cpp (17 lines)

Diff 71132

View Options

ksgrd/SensorAgent.h

Loading...
View Options

ksgrd/SensorAgent.cpp

Loading...