Differential D23577

add system integration to NSIS installer of KDE Connect
ClosedPublic
Actions

Authored by brute4s99 on Aug 30 2019, 11:56 AM.

Details

Reviewers
vonreth
albertvaka
sredman
Commits
R877:8524e3874bc5: add system integration to NSIS installer of KDE Connect
Summary

https://i.imgur.com/4OYaaWW.jpg

Test Plan

install this to test : https://drive.google.com/file/d/1WAYnVDrgXvWR6EQ50tOgfFdQKv_fTC7s/view?usp=sharing

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
brute4s99 requested review of this revision.Aug 30 2019, 11:56 AM
brute4s99 created this revision.
brute4s99 edited the test plan for this revision. (Show Details)Aug 30 2019, 11:56 AM
brute4s99 edited the summary of this revision. (Show Details)Aug 30 2019, 12:02 PM
vonreth accepted this revision.Aug 30 2019, 5:21 PM

I suggested a change. Rest looks good.

extragear/kdeconnect-kde/kdeconnect-kde.py
38

I don't think you need that define, just use it directly in the shortcut creation.

This revision is now accepted and ready to land.Aug 30 2019, 5:21 PM
brute4s99 added inline comments.Aug 31 2019, 2:12 AM
extragear/kdeconnect-kde/kdeconnect-kde.py
38

I've actually been meaning to keep the NSIS scripts pristine, as I want other projects to pick up on these if they want to adopt SnoreToast for their projects. Can I keep it please? 😅

Closed by commit R877:8524e3874bc5: add system integration to NSIS installer of KDE Connect (authored by brute4s99). · Explain WhySep 3 2019, 5:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65348

View Options

extragear/kdeconnect-kde/kdeconnect-kde.py

Loading...