Differential D23564

[effects/slidingpopups] Don't start animation if there is no slide edge
ClosedPublic
Actions

Authored by zzag on Aug 29 2019, 1:09 PM.

Details

Reviewers
None
Group Reviewers
KWin
Commits
R108:5469558c1a49: [effects/slidingpopups] Don't start animation if there is no slide edge
Summary

Given that slide in/out animation duration is not initialized when slide
location is NoEdge, assert statement will be triggered in slideIn().

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 29 2019, 1:09 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 29 2019, 1:09 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 29 2019, 1:09 PM
zzag added a comment.Aug 29 2019, 1:10 PM

You need D18564 to test this revision.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 23 2019, 3:47 PM
Closed by commit R108:5469558c1a49: [effects/slidingpopups] Don't start animation if there is no slide edge (authored by zzag). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66674

View Options

effects/slidingpopups/slidingpopups.cpp

Loading...