Differential D23561

[autotests] Don't test wl-shell clients
ClosedPublic
Actions

Authored by zzag on Aug 29 2019, 1:07 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

R108:d92d6e77ae87: [autotests] Don't test wl-shell clients

Summary

This change removes all traces of wl-shell in the test suite. That's a
prerequisite for dropping wl-shell support in KWin.

Given that wl-shell and xdg-shell are not interchangeable, some tests
were removed and initialization sequence in some tests was adjusted.

The most notable change is ensuring that each plasmashell window sets
its role and initial position before committing the surface. Setting
those properties before the first surface commit is important because
our window placement code needs to know window type in order to
avoid maximizing panels, popups, etc.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.Aug 29 2019, 1:07 PM

Restricted Application added a project: KWin. · View Herald TranscriptAug 29 2019, 1:07 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Aug 29 2019, 1:07 PM

Harbormaster completed remote builds in B15811: Diff 64937.Aug 29 2019, 1:07 PM

zzag added a dependency: D22810: Port QPA away from Wayland.Aug 29 2019, 1:08 PM

zzag added a dependent revision: D23562: [wayland] Drop wl-shell support.

zzag added a dependent revision: D23563: [platforms/wayland] Drop wl-shell support.

zzag edited the summary of this revision. (Show Details)Sep 6 2019, 9:37 AM

davidedmundson accepted this revision.Sep 6 2019, 9:59 AM

This revision is now accepted and ready to land.Sep 6 2019, 9:59 AM

Closed by commit R108:d92d6e77ae87: [autotests] Don't test wl-shell clients (authored by zzag). · Explain WhySep 23 2019, 4:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/integration/CMakeLists.txt (2 lines)
M		autotests/integration/dbus_interface_test.cpp (33 lines)
M		autotests/integration/debug_console_test.cpp (12 lines)
M		autotests/integration/decoration_input_test.cpp (242 lines)
M		autotests/integration/dont_crash_cancel_animation.cpp (3 lines)
M		autotests/integration/dont_crash_cursor_physical_size_empty.cpp (14 lines)
M		autotests/integration/dont_crash_no_border.cpp (14 lines)
M		autotests/integration/dont_crash_useractions_menu.cpp (3 lines)
M		autotests/integration/effects/fade_test.cpp (13 lines)
M		autotests/integration/effects/maximize_animation_test.cpp (10 lines)
M		autotests/integration/effects/slidingpopups_test.cpp (3 lines)
M		autotests/integration/effects/windowgeometry_test.cpp (1 line)
M		autotests/integration/effects/wobbly_shade_test.cpp (1 line)
M		autotests/integration/globalshortcuts_test.cpp (7 lines)
M		autotests/integration/idle_inhibition_test.cpp (16 lines)
M		autotests/integration/input_stacking_order.cpp (14 lines)
M		autotests/integration/internal_window.cpp (3 lines)
M		autotests/integration/keyboard_layout_test.cpp (9 lines)
M		autotests/integration/kwin_wayland_test.h (18 lines)
M		autotests/integration/kwinbindings_test.cpp (19 lines)
M		autotests/integration/lockscreen.cpp (4 lines)
M		autotests/integration/maximize_test.cpp (169 lines)
M		autotests/integration/move_resize_window_test.cpp (58 lines)
M		autotests/integration/placement_test.cpp (1 line)
M		autotests/integration/plasma_surface_test.cpp (66 lines)
M		autotests/integration/plasmawindow_test.cpp (62 lines)
M		autotests/integration/pointer_constraints_test.cpp (63 lines)
M		autotests/integration/pointer_input.cpp (106 lines)
M		autotests/integration/quick_tiling_test.cpp (188 lines)
M		autotests/integration/scene_opengl_shadow_test.cpp (9 lines)
M		autotests/integration/scene_qpainter_shadow_test.cpp (7 lines)
M		autotests/integration/scene_qpainter_test.cpp (28 lines)
M		autotests/integration/shell_client_rules_test.cpp (154 lines)
M		autotests/integration/shell_client_test.cpp (420 lines)
M		autotests/integration/showing_desktop_test.cpp (11 lines)
M		autotests/integration/stacking_order_test.cpp (61 lines)
D	M	autotests/integration/start_test.cpp (164 lines)
M		autotests/integration/struts_test.cpp (23 lines)
M		autotests/integration/tabbox_test.cpp (18 lines)
M		autotests/integration/test_helpers.cpp (52 lines)
M		autotests/integration/touch_input_test.cpp (3 lines)
D	M	autotests/integration/transient_no_input_test.cpp (115 lines)
M		autotests/integration/transient_placement.cpp (133 lines)
M		autotests/integration/virtual_desktop_test.cpp (39 lines)
M		autotests/integration/window_selection_test.cpp (13 lines)
M		autotests/integration/x11_client_test.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	64937	402bc79		Aug 29 2019, 1:07 PM	★	★
Diff 2	66682	bebe812	R108:d92d6e77ae87157de2f396fc6536d58407bbaa4c	Sep 23 2019, 2:28 PM	★	★

Status	Author	Revision
Closed	zzag	D23589 Rename ShellClient to XdgShellClient
Closed	zzag	D23573 [wayland] Drop xdg-shell v5 support
Closed	zzag	D23562 [wayland] Drop wl-shell support
Closed	zzag	D23563 [platforms/wayland] Drop wl-shell support
Closed	zzag	D23561 [autotests] Don't test wl-shell clients
Closed	zzag	D22810 Port QPA away from Wayland

[autotests] Don't test wl-shell clientsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 66682

autotests/integration/CMakeLists.txt

autotests/integration/dbus_interface_test.cpp

autotests/integration/debug_console_test.cpp

autotests/integration/decoration_input_test.cpp

autotests/integration/dont_crash_cancel_animation.cpp

autotests/integration/dont_crash_cursor_physical_size_empty.cpp

autotests/integration/dont_crash_no_border.cpp

autotests/integration/dont_crash_useractions_menu.cpp

autotests/integration/effects/fade_test.cpp

autotests/integration/effects/maximize_animation_test.cpp

autotests/integration/effects/slidingpopups_test.cpp

autotests/integration/effects/windowgeometry_test.cpp

autotests/integration/effects/wobbly_shade_test.cpp

autotests/integration/globalshortcuts_test.cpp

autotests/integration/idle_inhibition_test.cpp

autotests/integration/input_stacking_order.cpp

autotests/integration/internal_window.cpp

autotests/integration/keyboard_layout_test.cpp

autotests/integration/kwin_wayland_test.h

autotests/integration/kwinbindings_test.cpp

autotests/integration/lockscreen.cpp

autotests/integration/maximize_test.cpp

autotests/integration/move_resize_window_test.cpp

autotests/integration/placement_test.cpp

autotests/integration/plasma_surface_test.cpp

autotests/integration/plasmawindow_test.cpp

autotests/integration/pointer_constraints_test.cpp

autotests/integration/pointer_input.cpp

autotests/integration/quick_tiling_test.cpp

autotests/integration/scene_opengl_shadow_test.cpp

autotests/integration/scene_qpainter_shadow_test.cpp

autotests/integration/scene_qpainter_test.cpp

autotests/integration/shell_client_rules_test.cpp

autotests/integration/shell_client_test.cpp

autotests/integration/showing_desktop_test.cpp

autotests/integration/stacking_order_test.cpp

autotests/integration/start_test.cpp

autotests/integration/struts_test.cpp

autotests/integration/tabbox_test.cpp

autotests/integration/test_helpers.cpp

autotests/integration/touch_input_test.cpp

autotests/integration/transient_no_input_test.cpp

autotests/integration/transient_placement.cpp

autotests/integration/virtual_desktop_test.cpp

autotests/integration/window_selection_test.cpp

autotests/integration/x11_client_test.cpp

[autotests] Don't test wl-shell clients
ClosedPublic
Actions

Revision Contents
Changeset List