[autotests] Don't test wl-shell clients
ClosedPublic

Authored by zzag on Aug 29 2019, 1:07 PM.

Details

Summary

This change removes all traces of wl-shell in the test suite. That's a
prerequisite for dropping wl-shell support in KWin.

Given that wl-shell and xdg-shell are not interchangeable, some tests
were removed and initialization sequence in some tests was adjusted.

The most notable change is ensuring that each plasmashell window sets
its role and initial position before committing the surface. Setting
those properties before the first surface commit is important because
our window placement code needs to know window type in order to
avoid maximizing panels, popups, etc.

Diff Detail

Repository
R108 KWin
Lint
Lint ErrorsExcuse: cppcheck is dumb
SeverityLocationCodeMessage
Errorautotests/integration/kwin_wayland_test.h:218CppcheckunknownMacro
Errorautotests/integration/shell_client_rules_test.cpp:407CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:408CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:486CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:487CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:546CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:547CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:687CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:688CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1954CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1955CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2007CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2008CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2064CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2065CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2182CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2183CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2265CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2266CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2311CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2312CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2359CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2360CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2453CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:2454CppcheckdoubleFree
Unit
No Unit Test Coverage
Build Status
Buildable 15811
Build 15829: arc lint + arc unit
zzag created this revision.Aug 29 2019, 1:07 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 29 2019, 1:07 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 29 2019, 1:07 PM
zzag edited the summary of this revision. (Show Details)Sep 6 2019, 9:37 AM
davidedmundson accepted this revision.Sep 6 2019, 9:59 AM
This revision is now accepted and ready to land.Sep 6 2019, 9:59 AM
This revision was automatically updated to reflect the committed changes.