Adapt tests corresponding to changes in D7446
The placesitemmodeltest were not run due to KIO_VERSION not existing
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:8645ed68a15f: Update dolphin tests following place changes D7446
LANG="en" ctest
Diff Detail
- Repository
- R318 Dolphin
- Branch
- arcpatch-D23557_1
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16487 Build 16505: arc lint + arc unit
Why does the kio test check whether we have recentlyused:/ around, while this one doesn't?
src/tests/CMakeLists.txt | ||
---|---|---|
74 | Don't forget to bump the version :) |
src/tests/CMakeLists.txt | ||
---|---|---|
74 | I committed this fix separately on your behalf on the stable branch, please rebase this patch. Which brings the question: should we push this patch to 19.08? Probably yes. |
@meven Looks like this patch is not enough: https://build.kde.org/job/Applications/job/dolphin/job/kf5-qt5%20SUSEQt5.12/78/testReport/projectroot.src/tests/placesitemmodeltest/
Could you have a look?
It seems to me the test fails because is uses an older kio version than 5.63 with D7446 applied creating "Recently Saved" group instead of group "Recent".
FAIL! : PlacesItemModelTest::testGroups() Compared values are not the same
Actual (groups.at(2).second.toString()): "Recently Saved" Expected (QStringLiteral("Recent")) : "Recent"
The actual shows that the old "Recently Saved" group was created when it should not have been.
I don't know how this jenkins job works, but I would recommend cleaning the cached artifact KIO 5.63.0 for dolphin somehow.
We can alternatively limit this test run only on KF5 >= 5.64