Differential D23553

Replace Wayland/XDG outputs checks with enablement checks
ClosedPublic
Actions

Authored by romangg on Aug 28 2019, 11:43 PM.

Details

Reviewers
None
Group Reviewers
KWin
Commits
R108:b3e7664d2cd2: Replace Wayland/XDG outputs checks with enablement checks
Summary

Make it more explicit what the relation is between Wayland and XDG objects
existing and enablement:

The ouput is enabled if and only if Wayland and XDG output objects exist.

We can simplify the code by replacing checks on the outputs with checking
the current enablement value.

Test Plan

Wayland nested and virtual backends.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Aug 28 2019, 11:43 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 28 2019, 11:43 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Aug 28 2019, 11:43 PM
romangg planned changes to this revision.Aug 29 2019, 10:08 AM

In order to not send wl_output data changes needlessly often this needs some more work on init.

romangg updated this revision to Diff 64945.Aug 29 2019, 1:54 PM
  • Init Wayland output with device output
romangg updated this revision to Diff 64949.Aug 29 2019, 2:33 PM

Rebase on master.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 5 2019, 3:29 PM
Closed by commit R108:b3e7664d2cd2: Replace Wayland/XDG outputs checks with enablement checks (authored by romangg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65442

View Options

abstract_wayland_output.h

Loading...
View Options

abstract_wayland_output.cpp

Loading...
View Options

plugins/platforms/drm/drm_output.cpp

Loading...
View Options

plugins/platforms/fbdev/fb_backend.cpp

Loading...
View Options

plugins/platforms/hwcomposer/hwcomposer_backend.cpp

Loading...
View Options

plugins/platforms/virtual/virtual_output.cpp

Loading...
View Options

plugins/platforms/wayland/wayland_output.cpp

Loading...
View Options

plugins/platforms/x11/windowed/x11windowed_output.cpp

Loading...