WIP: Jekyll version
Needs ReviewPublic

Authored by ognarb on Aug 28 2019, 6:28 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T11466: Update Umbrello website

Diff Detail

Repository
R970 Umbrello Website
Branch
jekyll
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15765
Build 15783: arc lint + arc unit
ognarb created this revision.Aug 28 2019, 6:28 PM
Restricted Application added a project: Umbrello. · View Herald TranscriptAug 28 2019, 6:28 PM
Restricted Application added a subscriber: umbrello-devel. · View Herald Transcript
ognarb requested review of this revision.Aug 28 2019, 6:28 PM

Thanks for doing this work.

I tried to run it locally on openSUSE_Leap_15.1 by executing the commands mentioned in README.md and got the following error message:

$:~/src/websites/umbrello-kde-org>gem install bundler jekyll
.... 
$:~/src/websites/umbrello-kde-org> bundle install --path vendor/bundle
The path `/home/xxx/src/websites/kde-jekyll-theme` does not exist.

Any idea how to solve this issue ?

habacker added inline comments.Aug 29 2019, 6:00 PM
Gemfile
5

The path ../kde-jekyll-theme does not match the path the kde jekyll theme is installed, when fetching from https://invent.kde.org/websites/jekyll-kde-theme.git. Why not using this path in Gemfile by default ?

README.md
13

Running this command returns

...
    Server address: http://127.0.0.1:4000/
  Server running... press ctrl-c to stop.
[2019-08-29 19:53:43] ERROR `/"$imageFilePath/"' not found.
features.md
250

Php code is not interpreted on the local installation. The script itself is displayed.

ognarb updated this revision to Diff 64961.Aug 29 2019, 6:06 PM
ognarb marked an inline comment as done.
  • Change local path

I was using a local version (that was unreleased until 4 days ago) ;)

ognarb added inline comments.Aug 29 2019, 6:09 PM
features.md
250

This is still WIP I still need to convert the data to yaml

habacker added inline comments.Aug 29 2019, 6:21 PM
_posts/2019-08-18-umbrello-2-29-releases-available.md
7

The links need to be prefixed with '/'