Differential D23533

Initialise default styles just once; display an icon for points
ClosedPublic
Actions

Authored by zaitseff on Aug 28 2019, 11:21 AM.

Details

Reviewers
rahn
Commits
R34:1eae0a397a3c: Initialise default styles just once; display an icon for points. Previously…
Summary

Previously, default styles would be constructed for every placemark. Now create the default styles just once, then copy as required.

In addition, now display an icon for placemarks with points, but not for lines or polygons. Currently, the icon cannot be styled with the Simplestyle properties "marker-size", "marker-symbol" or "marker-color": this is yet to be implemented.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zaitseff created this revision.Aug 28 2019, 11:21 AM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptAug 28 2019, 11:21 AM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
zaitseff requested review of this revision.Aug 28 2019, 11:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 2 2019, 2:14 PM
Closed by commit R34:1eae0a397a3c: Initialise default styles just once; display an icon for points. Previously… (authored by zaitseff, committed by rahn). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65251

View Options

src/plugins/runner/json/JsonParser.h

Loading...
View Options

src/plugins/runner/json/JsonParser.cpp

Loading...