Differential D23516

Fix for all themes: allow turn off attributes in XML highlighting files
ClosedPublic
Actions

Authored by nibags on Aug 27 2019, 9:47 PM.

Details

Reviewers
cullmann
vkrause
dhaumann
Group Reviewers
KTextEditor
Commits
R39:00721e80b5b4: Fix for all themes: allow turn off attributes in XML highlighting files
Summary

Depends on D23515

Use the new functions of KSyntaxHighlighting to verify if the bold, italic, underline & strikeout attributes are set in the XML files, so as to allow them to be turned off correctly in the themes that don't exist in KSyntaxHighlighting and that are applied by KTextEditor.

Diff Detail

Repository
R39 KTextEditor
Branch
turnoff-attr
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15721
Build 15739: arc lint + arc unit
nibags created this revision.Aug 27 2019, 9:47 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 27 2019, 9:47 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags requested review of this revision.Aug 27 2019, 9:47 PM
dhaumann added a comment.Aug 28 2019, 6:12 AM

I like it, although this all will not be needed anymore oncee KTextEditor is fully ported to KSyntaxHighlighting::Theme. Still a long way to go.

+1

nibags updated this revision to Diff 65018.Aug 30 2019, 9:15 PM
  • Update function names
cullmann accepted this revision.Sep 1 2019, 3:31 PM

I think this is fine, as soon as the other patch is in, feel free to commit!

This revision is now accepted and ready to land.Sep 1 2019, 3:31 PM
dhaumann accepted this revision.Sep 1 2019, 8:11 PM
Closed by commit R39:00721e80b5b4: Fix for all themes: allow turn off attributes in XML highlighting files (authored by nibags, committed by cullmann). · Explain WhySep 1 2019, 9:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/syntax/katehighlight.cpp (41 lines)

Diff 64780

View Options

src/syntax/katehighlight.cpp

Loading...