I am thinking about whether overwritesBold() , ... is better than definitionHasBold(). Because the Format matches an itemData in xml. Or even boldHardcoded().

Any thoughts?

PS: Another solution is to port all xml files to not use hard coded colors. That's a lot of work, though.

No idea if definitionhasBold or the other variants are better.
For the "PS: Another solution is to port all xml files to not use hard coded colors. That's a lot of work, though.": I think to hardcode e.g. bold/italic/... is actually not that bad in some cases. That can be themed nicely.

Shall we go with the definitionHasX style or change it?

As we have already members like

hasX

would it make sense to have

hasItalicOverride()

to be more consistent?

Yes, that is also fine with me, please do the changes and proceed.

I also like hasXXOverride().

In the case of bold, italic, underline and strikeout, functions such as hasXXOverride() are needed, since they are boolean values that can be turned off. But for the case color, selectedColor, backgroundColor and selectedBackgroundColor, do you think it's also necessary?

Because I think it's better not to add those functions; with the already existing functions hasTextColor(Theme) and hasBackgroundColor(Theme) is enough.

I believe you still need the hasTextColorOverride etc. hasTextColor is different and matches from the meaning isBold etc.

Background: The styleOverrides are yet another concept: if the user changes a color of a highlighting in the Highlighting Text Styles tab, then the style override is active. See http://blog.case.edu/bmb12/2007/03/06/kate_styles.png
That is: the style overrides are part of a Theme and typically only exist for Themes where the user changed colors.

But: Since the port to KSyntaxHighlighting::Theme is still not done, this currently is not used (iirc ???) in KTextEditor...

To make it short: if you want to know whether the colors are hardcoded, you also need the additional hasXxOverride() functions.

Dominik, ok with this now, too? Or did I miss some name issues in the API? (tried to read all lines for spelling mistakes :=)