Differential D23499

Fix context menu button for pages not showing up
ClosedPublic
Actions

Authored by ahiemstra on Aug 27 2019, 4:25 PM.

Details

Reviewers
mart
ngraham
Group Reviewers
Kirigami
Commits
R169:75652ff0f9af: Fix context menu button for pages not showing up
Summary

fd8fec5b introduced a difference between "action" and "kirigamiAction"
properties. PrivateActionToolButton only checks kirigamiAction so use
that for the context button as well.

Test Plan

Start kirigami gallery, go to the "buttons" page, see that it now has a
context menu again.

Diff Detail

Repository
R169 Kirigami
Branch
contextmenu_fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15701
Build 15719: arc lint + arc unit
ahiemstra created this revision.Aug 27 2019, 4:25 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptAug 27 2019, 4:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Aug 27 2019, 4:25 PM
ngraham accepted this revision.Aug 27 2019, 5:15 PM
This revision is now accepted and ready to land.Aug 27 2019, 5:15 PM
Closed by commit R169:75652ff0f9af: Fix context menu button for pages not showing up (authored by ahiemstra). · Explain WhyAug 27 2019, 7:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 64750

View Options

src/controls/private/globaltoolbar/ToolBarPageHeader.qml

Loading...