Make non-empty textual columns come first in sorting
ClosedPublic

Authored by nazark on Aug 27 2019, 6:43 AM.

Details

Summary

BUG: 410538

Current behavior of dolphin in sorting of files with textual columns (e.g. tags) is to show files without this particular textual column (e.g. without tags) first.
This patch changes this behavior so that dolphin shows the files with some value before the files without any value for chosen sorting method.

Test Plan

Sorting by name (isn't affected by the patch): https://i.imgur.com/eqbYwyZ.png
Sorting by textual column ("tags" in this particular example),
old version (non-tagged files and folders come first): https://i.imgur.com/5KLLujU.png
patched version (tagged files and folders come first): https://i.imgur.com/oUAeZ2z.png

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nazark created this revision.Aug 27 2019, 6:43 AM
Restricted Application added a subscriber: kfm-devel. · View Herald TranscriptAug 27 2019, 6:43 AM
nazark requested review of this revision.Aug 27 2019, 6:43 AM

If this is not a desired default behavior, I'll need some hints on how to make a setting for it.

ngraham added a subscriber: ngraham.

Some more description in the Summary section would be appreciated (e.g. what this is all about, what the problem currently is, how this fixes it), as well as before-and-after screenshots in the Test Plan section.

nazark edited the summary of this revision. (Show Details)Aug 27 2019, 3:54 PM
nazark edited the test plan for this revision. (Show Details)

Done

nazark edited the summary of this revision. (Show Details)Aug 27 2019, 3:56 PM
ngraham accepted this revision.Aug 27 2019, 4:17 PM
ngraham added a subscriber: elvisangelaccio.

Thanks, works great. Seems like a straightforward bugfix to me.

@elvisangelaccio?

This revision is now accepted and ready to land.Aug 27 2019, 4:17 PM
elvisangelaccio accepted this revision.Sep 1 2019, 3:53 PM

Thanks, I'll push to master since it could be considered a behavior change ;)

This revision was automatically updated to reflect the committed changes.