Differential D23477

[platforms/virtual] Create output devices
ClosedPublic
Actions

Authored by romangg on Aug 26 2019, 9:34 PM.

Details

Reviewers

None

Group Reviewers

KWin

Maniphest Tasks

T11459: AbstractWaylandOutput and output device consolidation

Commits

R108:cd6b69a4d2db: [platforms/virtual] Create output devices

Summary

Create output devices in virtual backend. For that the setVirtualOutputs call
can only come after the Wayland server has been initiliazied such that the
display exists to create the output and output device interfaces. Tests have
been adjusted for that.

Test Plan

98% tests passed, 3 tests failed out of 148

Total Test time (real) = 362.97 sec

The following tests FAILED:
         33 - kwin-testInternalWindow (Failed)
         39 - kwin-testPointerInput (Failed)
        101 - kwin-testMoveResize (Failed)

Failing of these tests looks unrelated to the change.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Aug 26 2019, 9:34 PM

Restricted Application added a project: KWin. · View Herald TranscriptAug 26 2019, 9:34 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

romangg requested review of this revision.Aug 26 2019, 9:34 PM

Harbormaster completed remote builds in B15677: Diff 64702.Aug 26 2019, 9:34 PM

romangg mentioned this in T11459: AbstractWaylandOutput and output device consolidation.Aug 26 2019, 10:40 PM

romangg added a task: T11459: AbstractWaylandOutput and output device consolidation.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2019, 10:24 AM

Closed by commit R108:cd6b69a4d2db: [platforms/virtual] Create output devices (authored by romangg). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/activities_test.cpp (2 lines)
M			autotests/integration/colorcorrect_nightcolor_test.cpp (2 lines)
M			autotests/integration/debug_console_test.cpp (2 lines)
M			autotests/integration/decoration_input_test.cpp (2 lines)
M			autotests/integration/desktop_window_x11_test.cpp (2 lines)
M			autotests/integration/dont_crash_aurorae_destroy_deco.cpp (2 lines)
M			autotests/integration/dont_crash_empty_deco.cpp (2 lines)
M			autotests/integration/dont_crash_no_border.cpp (2 lines)
M			autotests/integration/dont_crash_reinitialize_compositor.cpp (2 lines)
M			autotests/integration/dont_crash_useractions_menu.cpp (2 lines)
M			autotests/integration/input_stacking_order.cpp (2 lines)
M			autotests/integration/internal_window.cpp (2 lines)
M			autotests/integration/lockscreen.cpp (2 lines)
M			autotests/integration/maximize_test.cpp (2 lines)
M			autotests/integration/placement.cpp (2 lines)
M			autotests/integration/plasmawindow_test.cpp (2 lines)
M			autotests/integration/pointer_constraints_test.cpp (2 lines)
M			autotests/integration/pointer_input.cpp (2 lines)
M			autotests/integration/quick_tiling_test.cpp (2 lines)
M			autotests/integration/screenedge_client_show_test.cpp (2 lines)
M			autotests/integration/shade_test.cpp (2 lines)
M			autotests/integration/shell_client_rules_test.cpp (2 lines)
M			autotests/integration/shell_client_test.cpp (2 lines)
M			autotests/integration/struts_test.cpp (2 lines)
M			autotests/integration/touch_input_test.cpp (2 lines)
M			autotests/integration/transient_placement.cpp (2 lines)
M			autotests/integration/window_rules_test.cpp (2 lines)
M			autotests/integration/window_selection_test.cpp (2 lines)
M			autotests/integration/xwayland_input_test.cpp (2 lines)
M			autotests/integration/xwayland_selections_test.cpp (2 lines)
M			plugins/platforms/virtual/virtual_backend.cpp (17 lines)
M			plugins/platforms/virtual/virtual_output.h (2 lines)
M			plugins/platforms/virtual/virtual_output.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	64702	0301c08		Aug 26 2019, 9:34 PM	★	★
Diff 2	64722	f013a43	R108:cd6b69a4d2dbcf1c2404f1404db34abde4e2f7c5	Aug 27 2019, 10:24 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
3600f6caa499	2f26ef322ab3	0301c0866a1b	Roman Gilg	[platforms/virtual] Create output devices (Show More…)	Aug 26 2019, 9:16 PM

[platforms/virtual] Create output devicesClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 64722

autotests/integration/activities_test.cpp

autotests/integration/colorcorrect_nightcolor_test.cpp

autotests/integration/debug_console_test.cpp

autotests/integration/decoration_input_test.cpp

autotests/integration/desktop_window_x11_test.cpp

autotests/integration/dont_crash_aurorae_destroy_deco.cpp

autotests/integration/dont_crash_empty_deco.cpp

autotests/integration/dont_crash_no_border.cpp

autotests/integration/dont_crash_reinitialize_compositor.cpp

autotests/integration/dont_crash_useractions_menu.cpp

autotests/integration/input_stacking_order.cpp

autotests/integration/internal_window.cpp

autotests/integration/lockscreen.cpp

autotests/integration/maximize_test.cpp

autotests/integration/placement.cpp

autotests/integration/plasmawindow_test.cpp

autotests/integration/pointer_constraints_test.cpp

autotests/integration/pointer_input.cpp

autotests/integration/quick_tiling_test.cpp

autotests/integration/screenedge_client_show_test.cpp

autotests/integration/shade_test.cpp

autotests/integration/shell_client_rules_test.cpp

autotests/integration/shell_client_test.cpp

autotests/integration/struts_test.cpp

autotests/integration/touch_input_test.cpp

autotests/integration/transient_placement.cpp

autotests/integration/window_rules_test.cpp

autotests/integration/window_selection_test.cpp

autotests/integration/xwayland_input_test.cpp

autotests/integration/xwayland_selections_test.cpp

plugins/platforms/virtual/virtual_backend.cpp

plugins/platforms/virtual/virtual_output.h

plugins/platforms/virtual/virtual_output.cpp

[platforms/virtual] Create output devices
ClosedPublic
Actions

Revision Contents
Changeset List