The recent app wasn't displayed if it's recent *and* favorites.
Details
Details
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- removeMagicFiltering
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15651 Build 15669: arc lint + arc unit
| applets/kicker/plugin/recentusagemodel.cpp | ||
|---|---|---|
| 98 | This is doing two things.
We definitely still want 1. 2 definitely makes sense to be optional, even off by default, but simply removing it will change kicker. Is there a reason to change kicker? If not, it needs to be a property. | |
Comment Actions
- Revert "Remove 'magic' filtering of recent apps"
- Remove filtering of recent apps that are in the favorites
Comment Actions
It does introduce a bahavior change in kicker, tough we tought that ux-wise it was a really bad behavior that ought to be "fixed"
This comment was removed by mart.
Comment Actions
- Revert "Remove filtering of recent apps that are in the favorites"
- Add a new Q_PROPERTY to the Recents Model to filter out or not favorites
| applets/kicker/plugin/recentusagemodel.cpp | ||
|---|---|---|
| 453 | If this is called before refresh model will be null, and then we don't update m_showAllRecent This needs to be outside the if statement. Or you can simplify the whole thing and just use refresh() | |
| applets/kicker/plugin/recentusagemodel.h | ||
| 40 | We can't say "Current kicker" as people will read this in the future. I would write it as "filterFavourites" as that explains better what the opposite of showAll is. | |
Comment Actions
In general I'm not a big fan of this kind of pseudo-smart behavior. Unless it's perfect, the smartness winds up looking buggy in various cases. I'm in favor of removing the behavior entirely.
Comment Actions
@ngraham I agree with you completely. it's basically removing a bit of code, smaller patch and the code behaves without surprises.