The recent app wasn't displayed if it's recent *and* favorites.
This is doing two things.
We definitely still want 1.
2 definitely makes sense to be optional, even off by default, but simply removing it will change kicker.
Is there a reason to change kicker? If not, it needs to be a property.
If this is called before refresh model will be null, and then we don't update m_showAllRecent
This needs to be outside the if statement.
Or you can simplify the whole thing and just use refresh()
We can't say "Current kicker" as people will read this in the future.
I would write it as "filterFavourites" as that explains better what the opposite of showAll is.
In general I'm not a big fan of this kind of pseudo-smart behavior. Unless it's perfect, the smartness winds up looking buggy in various cases. I'm in favor of removing the behavior entirely.