Differential D23456

Clean up the renaming of m_instance tabs
ClosedPublic
Actions

Authored by rizzitello on Aug 25 2019, 9:10 PM.

Details

Reviewers
tcanabrava
patrickelectric
laysrodrigues
Commits
R231:15b6613cd8ac: Clean up the renaming of m_instance tabs
R231:eb3536b154cd: Merge branch 'cleanerTabRename' into 'master'
Summary

Clean up the renaming of m_instance tabs, Its generally frowned upon to use sender() in OOP code. I've fixed this with a lambda

Diff Detail

Repository
R231 Atelier
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello requested review of this revision.Aug 25 2019, 9:10 PM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Aug 25 2019, 9:11 PM
rizzitello added reviewers: tcanabrava, patrickelectric, laysrodrigues.
rizzitello added a project: Atelier.
rizzitello added a subscriber: Atelier.
laysrodrigues accepted this revision.Aug 28 2019, 1:36 PM
This revision is now accepted and ready to land.Aug 28 2019, 1:36 PM
Closed by commit R231:15b6613cd8ac: Clean up the renaming of m_instance tabs (authored by rizzitello). · Explain WhySep 23 2019, 11:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/mainwindow.h (1 line)
Msrc/mainwindow.cpp (9 lines)

Diff 66654

View Options

src/mainwindow.h

Loading...
View Options

src/mainwindow.cpp

Loading...