Fixing bug where split view opens with no URLs
ClosedPublic

Authored by feverfew on Aug 25 2019, 4:21 PM.

Details

Summary

BUG: 411193
FIXED-IN: 19.08.1

Test Plan

Reproduce steps as given in bug report. Observe the exected result.
Used qdbusviewer and ShowFolders method to observe that no regressions occured
in the "open new folders in tabs" feature.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
feverfew created this revision.Aug 25 2019, 4:21 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptAug 25 2019, 4:21 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
feverfew requested review of this revision.Aug 25 2019, 4:21 PM
ngraham accepted this revision.Aug 25 2019, 4:28 PM

Thanks for the quick fix. Stable branch please!

This revision is now accepted and ready to land.Aug 25 2019, 4:28 PM
elvisangelaccio accepted this revision.Aug 25 2019, 4:32 PM

Thanks for the quick fix. Stable branch please!

Still not commit access (probably because of bugs like these...), please commit for me :)

Will do.

I thought all GSoC students needed to have commit access though? Please apply. https://community.kde.org/Infrastructure/Get_a_Developer_Account

This revision was automatically updated to reflect the committed changes.

Will do.

I thought all GSoC students needed to have commit access though? Please apply. https://community.kde.org/Infrastructure/Get_a_Developer_Account

KIOFuse isn't on KDE infrastructure (it's still technically not a KDE project yet), so it hasn't been strictly necessary. I did apply, not sure where the application has gone. I'll reapply.

elvisangelaccio added a comment.EditedAug 25 2019, 4:42 PM

Thanks for the quick fix. Stable branch please!

Still not commit access (probably because of bugs like these...), please commit for me :)

I can assure you that even an experienced developer might not notice such bugs ;)