Differential D23426

Include KDE* cmake macros before any others
ClosedPublic
Actions

Authored by arojas on Aug 25 2019, 12:01 PM.

Details

Reviewers
None
Group Reviewers
KDE PIM
Commits
R176:9cb25cd0672e: Include KDE* cmake macros before any others
Summary

They may influence other imports - in particular, ECMGeneratePriFile uses KDE_INSTALL_USE_QT_SYS_PATH, which is initialized in KDEInstallDirs, to determine the mkspecs install dir

Test Plan

Build 19.08 without setting CMAKE_INSTALL_PREFIX, pri file is installed in the right place

Diff Detail

Repository
R176 PIM: KIdentity Management
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Aug 25 2019, 12:01 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 25 2019, 12:01 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
arojas requested review of this revision.Aug 25 2019, 12:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 25 2019, 1:14 PM
Closed by commit R176:9cb25cd0672e: Include KDE* cmake macros before any others (authored by arojas). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (7 lines)

Diff 64569

View Options

CMakeLists.txt

Loading...