Differential D23423

Include KDE* cmake macros before any others
ClosedPublic
Actions

Authored by arojas on Aug 25 2019, 11:44 AM.

Details

Reviewers
vkrause
Group Reviewers
KDE PIM
Commits
R174:2dd0d671001a: Include KDE* cmake macros before any others
Summary

They may influence other imports - in particular, ECMGeneratePriFile uses KDE_INSTALL_USE_QT_SYS_PATH, which is initialized in KDEInstallDirs, to determine the mkspecs install dir

Test Plan

Build 16.08 without setting CMAKE_INSTALL_PREFIX, pri file is installed in the right place

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Aug 25 2019, 11:44 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 25 2019, 11:44 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
arojas requested review of this revision.Aug 25 2019, 11:44 AM
vkrause accepted this revision.Aug 25 2019, 12:58 PM
vkrause added a subscriber: vkrause.

Thanks, consider the other similar patches accepted as well :)

This revision is now accepted and ready to land.Aug 25 2019, 12:58 PM
Closed by commit R174:2dd0d671001a: Include KDE* cmake macros before any others (authored by arojas). · Explain WhyAug 25 2019, 2:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (7 lines)

Diff 64588

View Options

CMakeLists.txt

Loading...