This change adds a new option for searching the selected text inside the document. The following image explains the proposed solution:
In this short video, we can see the proposed solution:
BUG: 408355
Details
Details
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Branch
- search_withing_document (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16150 Build 16168: arc lint + arc unit
Comment Actions
Works great. I have some UI suggestions below:
| ui/pageview.cpp | ||
|---|---|---|
| 4373 | This grammar change makes it wrong for all the other entries. Maybe the new "Search for <text> in open document" menu item should be in the base level of the context menu, and not inside the sub-menu. | |
| 4376 | The icon should be document-preview (document-open is used for actions that open documents) | |
| ui/pageview.cpp | ||
|---|---|---|
| 4373 | I was thinking about that because even if you don't have any external provider, you should have the option to search within the document. I didn't want to change to much the existing code, my fault. I will update taking into consideration your suggestion. | |
Comment Actions
It's possible the Okular people are all looking only at GitLab merge requests since Okular has migrated to GitLab.. It's possible you'll get more eyeballs on it if you re-submit this at https://invent.kde.org/kde/okular/merge_requests