| elvisangelaccio |
| Dolphin |
When you select the same sort order that's already selected, the currently-checked
sort order description (the human-readable ascending/descending items) gets unchecked
in slotSortTriggered() yet the ascending/descending items items only get checked in
slotSortOrderChanged(). Because the order hasn't gotten changed, neither one gets
checked again.
This patch fixes the problem by not unchecking them in the first place.
BUG: 411223
FIXED-IN: 19.08.2
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
A simpler alternative could be to use m_sortByActions, I have tested it.
foreach (QAction* groupAction, m_sortByActions.values()) {
KActionMenu* actionMenu = qobject_cast<KActionMenu*>(groupAction);
if (actionMenu) {
foreach (QAction* subAction, actionMenu->menu()->actions()) {
subAction->setChecked(false);
}
} else if (groupAction->actionGroup()) {
groupAction->setChecked(false);
}
}+1
Always nice when you can fix a bug by changing a single line of code :D
| src/views/dolphinviewactionhandler.cpp | ||
|---|---|---|
| 636–641 | Also please update this comment: for example "all other actions get unchecked excluding the ascending/descending actions" | |
| src/views/dolphinviewactionhandler.cpp | ||
|---|---|---|
| 643 | No need for values(), and while at it port away from foreach for (QAction *groupAction : qAsConst(m_sortByActions) | |