fix(mimetreeparser): Make it possible to distinguish different encrypted/signed message parts.
ClosedPublic

Authored by knauss on Aug 24 2019, 10:30 AM.

Details

Summary

This is mostly important for inline encrypted messages, as they don't have
a corresponding mime part.

That should finally make rendertest be happy again.

Test Plan

run rendertest

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss created this revision.Aug 24 2019, 10:30 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 24 2019, 10:30 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss requested review of this revision.Aug 24 2019, 10:30 AM

This doesn't fix rendertest in my kdepim docker. With the patch applied, RenderTest::testRenderIconic(openpgp-encrypted-no-text-attachment.mbox) now passes. However, RenderTest::testRenderInlined(openpgp-encrypted-no-text-attachment.mbox), which used to pass, now fails.

knauss added a comment.EditedAug 26 2019, 12:01 AM

This doesn't fix rendertest in my kdepim docker. With the patch applied, RenderTest::testRenderIconic(openpgp-encrypted-no-text-attachment.mbox) now passes. However, RenderTest::testRenderInlined(openpgp-encrypted-no-text-attachment.mbox), which used to pass, now fails.

Yeah sometimes one mail rendering fails. I'll investigate this if I find a pattern. But it is not everytime the same test, that fails and if I just run this specific test, that passes. Give it a try:

<builddir>/bin/redertest.shell testRenderInlined:openpgp-encrypted-no-text-attachment.mbox

at least for me, if I tried this the test passes everytime.

Oh, joy.
I ran "ctest -R rendertest -V | grep FAIL" a bunch of times. I always get 5 failures of testRenderSmart, testRenderInlined, testRenderIconic, testRenderHidden, and testRenderHeaderOnly when they process openpgp-inline-multiple.mbox. Sometimes those tests fail when processing openpgp-encrypted-no-text-attachment.mbox.

knauss added a comment.Sep 1 2019, 1:20 PM

I'll file this patch so we are able to debug the issue, why the tests are flaky.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 1 2019, 3:20 PM
This revision was automatically updated to reflect the committed changes.