This is mostly important for inline encrypted messages, as they don't have
a corresponding mime part.
That should finally make rendertest be happy again.
gjditchfield |
KDE PIM |
This is mostly important for inline encrypted messages, as they don't have
a corresponding mime part.
That should finally make rendertest be happy again.
run rendertest
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
This doesn't fix rendertest in my kdepim docker. With the patch applied, RenderTest::testRenderIconic(openpgp-encrypted-no-text-attachment.mbox) now passes. However, RenderTest::testRenderInlined(openpgp-encrypted-no-text-attachment.mbox), which used to pass, now fails.
Yeah sometimes one mail rendering fails. I'll investigate this if I find a pattern. But it is not everytime the same test, that fails and if I just run this specific test, that passes. Give it a try:
<builddir>/bin/redertest.shell testRenderInlined:openpgp-encrypted-no-text-attachment.mbox
at least for me, if I tried this the test passes everytime.
Oh, joy.
I ran "ctest -R rendertest -V | grep FAIL" a bunch of times. I always get 5 failures of testRenderSmart, testRenderInlined, testRenderIconic, testRenderHidden, and testRenderHeaderOnly when they process openpgp-inline-multiple.mbox. Sometimes those tests fail when processing openpgp-encrypted-no-text-attachment.mbox.