[Folder view] Scale selection and preview buttons with item size

Authored by ngraham on Aug 23 2019, 8:48 PM.



Right now the selection and preview buttons that appear on hover are very very tiny,
and remain very very tiny even when the icon size is large.

This patch increases the size--and therefore visibility and clickability--of the buttons
as the icon size increases.

BUG: 411073
FIXED-IN: 5.17.0

Test Plan

No change for icon sizes at slider positions 1, 2, and 3, where items are quite small.

Slider position 4:

Slider position 5:

Slider position 6:

Diff Detail

R119 Plasma Desktop
folderview-buttons-scale-with-item-size (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 15556
Build 15574: arc lint + arc unit
ngraham created this revision.Aug 23 2019, 8:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 23 2019, 8:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 23 2019, 8:48 PM
ngraham updated this revision to Diff 64447.Aug 23 2019, 8:53 PM

Slightly cleaner code

ndavis added a subscriber: ndavis.Sep 1 2019, 10:03 AM
ndavis added inline comments.

medium would be better because then it won't overlap with the icon/thumbnail

ngraham updated this revision to Diff 65127.Sep 1 2019, 2:22 PM

Use medium for largest size

ngraham edited the test plan for this revision. (Show Details)Sep 1 2019, 2:23 PM
ngraham marked an inline comment as done.
ndavis added a comment.Sep 1 2019, 2:25 PM

That's some nice consistent spacing. Does it get the icons from the desktop theme? If so, I could add some additional sizes so that it doesn't look as blurry.

ndavis accepted this revision.Sep 1 2019, 2:25 PM
This revision is now accepted and ready to land.Sep 1 2019, 2:25 PM

The icons are in the plasma theme.

This revision was automatically updated to reflect the committed changes.