Differential D23385

More porting from QRegExp to QRegularExpression
ClosedPublic
Actions

Authored by dhaumann on Aug 23 2019, 6:51 PM.

Details

Reviewers
cullmann
Commits
R39:88107e4f1f28: fix compile with Qt 5.11
R39:b5c37d88de4e: More porting from QRegExp to QRegularExpression
Summary

Less deprecated QRegExp usage.

Test Plan
  • KTextEditor::Commands tested, still work
  • make test is still green

Diff Detail

Repository
R39 KTextEditor
Branch
port-qregexp
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15553
Build 15571: arc lint + arc unit
dhaumann created this revision.Aug 23 2019, 6:51 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 23 2019, 6:51 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Aug 23 2019, 6:51 PM
cullmann requested changes to this revision.Aug 23 2019, 7:19 PM

I would tend to make more stuff "static const QRegularExpression", given QRegularExpression unlike QRegExp has not the issue of storing matches inside itself.

This revision now requires changes to proceed.Aug 23 2019, 7:19 PM
dhaumann updated this revision to Diff 64443.Aug 23 2019, 7:33 PM
  • Add static and const where applicable
cullmann accepted this revision.Aug 23 2019, 7:35 PM

Thanks!

This revision is now accepted and ready to land.Aug 23 2019, 7:35 PM
Closed by commit R39:b5c37d88de4e: More porting from QRegExp to QRegularExpression (authored by dhaumann). · Explain WhyAug 24 2019, 6:40 PM
This revision was automatically updated to reflect the committed changes.
dvratil added a subscriber: dvratil.Aug 28 2019, 2:51 PM
dvratil added inline comments.
src/document/katedocument.cpp
4676 ↗(On Diff #64441)

@dhaumann QRegularExpression::wildcardToRegularExpression() was introduced in Qt 5.12, but Frameworks depend on 5.11 :-( So this change breaks build...

dhaumann added a comment.Aug 28 2019, 6:28 PM

Oh, in that case can you or @cullmann simply revert this part or #ifdef it? I currently cannot at least until the weekend (sorry!).

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 64443

View Options

autotests/src/vimode/emulatedcommandbar.cpp

Loading...
View Options

autotests/src/vimode/fakecodecompletiontestmodel.cpp

Loading...
View Options

src/document/katedocument.cpp

Loading...
View Options

src/view/kateviewhelpers.cpp

Loading...
View Options

src/vimode/appcommands.h

Loading...
View Options

src/vimode/appcommands.cpp

Loading...
View Options

src/vimode/cmds.cpp

Loading...
View Options

src/vimode/completionreplayer.cpp

Loading...
View Options

src/vimode/emulatedcommandbar/commandmode.cpp

Loading...
View Options

src/vimode/emulatedcommandbar/completer.cpp

Loading...