Differential D23377

Don't make CssHelperBase::extraXCss() methods virtual
ClosedPublic
Actions

Authored by vkrause on Aug 23 2019, 2:41 PM.

Details

Reviewers
knauss
Commits
R94:4502b72b3541: Don't make CssHelperBase::extraXCss() methods virtual
Summary

Those are not overridden anywhere, so this isn't needed and makes it easier
to reason about this code.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Aug 23 2019, 2:41 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 23 2019, 2:41 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Aug 23 2019, 2:41 PM
knauss accepted this revision.Aug 23 2019, 2:49 PM
This revision is now accepted and ready to land.Aug 23 2019, 2:49 PM
Closed by commit R94:4502b72b3541: Don't make CssHelperBase::extraXCss() methods virtual (authored by vkrause). · Explain WhyAug 24 2019, 8:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 64461

View Options

messageviewer/src/viewer/csshelperbase.h

Loading...