Avoid anchor loop in NavigationActionBar

Authored by astippich on Aug 22 2019, 8:49 PM.



When opening albums in the albums view
containing cover art, Elisa was spitting
anchors loops and eventually crashed.
Since the image is in a layout, let it
scale the image and avoid the loop.

Diff Detail

R255 Elisa
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Aug 22 2019, 8:49 PM
astippich created this revision.

Don't know exactly why and when it started, but this bug makes Elisa quite unusable.

ngraham accepted this revision.Aug 22 2019, 9:59 PM

Yeah, this is my fault, sorry. I only recently learned that setting height and width directly on items in layouts is a bad idea. Feel free to fix other occurrences too with no review.

This revision is now accepted and ready to land.Aug 22 2019, 9:59 PM
This revision was automatically updated to reflect the committed changes.