Adding a modulo operator to the AlkValue class to avoid using gmp in kmymoney

Authored by habacker on Aug 22 2019, 8:24 PM.

Diff Detail

R471 Alkimia Library
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
habacker requested review of this revision.Aug 22 2019, 8:24 PM
habacker created this revision.
tbaumgart requested changes to this revision.Aug 23 2019, 6:21 AM

Other than that it looks ok to me.


Why don't you retrun an AlkValue here? It would seem more natural to me here, even though not used in your use case. But it does not hurt either.

This revision now requires changes to proceed.Aug 23 2019, 6:21 AM
habacker updated this revision to Diff 64391.Aug 23 2019, 6:42 AM
  • return AlkValue
tbaumgart accepted this revision.Aug 23 2019, 6:49 AM
This revision is now accepted and ready to land.Aug 23 2019, 6:49 AM
This revision was automatically updated to reflect the committed changes.