Remove unused file
ClosedPublic

Authored by vkrause on Thu, Aug 22, 4:39 PM.

Details

Test Plan

Tests still run as before, and I'm not finding any references to this, is this still needed for anything?

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Thu, Aug 22, 4:39 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptThu, Aug 22, 4:39 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Thu, Aug 22, 4:39 PM
knauss added a subscriber: knauss.Thu, Aug 22, 4:47 PM

Have you tested also test on kdepim-addons? and made sure, that you don't had leftovers in builddir or installdir?

Have you tested also test on kdepim-addons? and made sure, that you don't had leftovers in builddir or installdir?

It's not copied to the build dir, and it's also not installed, so addons can't be affected.

and you run all tests in messagelib? as the autotests data spread to templateparser and messageviewer. grep -r "MAIL_DATA_DIR="

and you run all tests in messagelib? as the autotests data spread to templateparser and messageviewer. grep -r "MAIL_DATA_DIR="

Yes.

Mmh okay somehow the test got lost while moving things around, the last reference I find is: b15cca2c03e53a9dfd0991ceece9053adaf8e07f
but the tests never ended in messageviewer. Intergestingly enough mlaurent adds server updates to that file ;D

Maybe it is good to restore the test especially as you are touching this part and move everything to messageviewer.

knauss accepted this revision.Thu, Aug 22, 7:15 PM

Other than that, it is a cleanup patch, that is fine so far.

This revision is now accepted and ready to land.Thu, Aug 22, 7:15 PM
This revision was automatically updated to reflect the committed changes.