Fix detection of window ID
ClosedPublic

Authored by stefanocrocco on Thu, Aug 22, 3:45 PM.

Details

Summary

Session cookies weren't correctly deleted on shutdown because the window
ID passed to KCookieServer::addCookies was always 0. Now, the correct id
is passed.

Test Plan

go to a page which creates session cookies (for example GMail), then
exit and open the Cookies KFM. Look at the cookies and check that there aren't
session cookies.

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
stefanocrocco requested review of this revision.Thu, Aug 22, 3:45 PM
stefanocrocco created this revision.

I think most understandable/readable would be to just use .testFlag()

Use QFlags::testFlag

dfaure accepted this revision.Thu, Aug 22, 8:48 PM
dfaure added inline comments.
webenginepart/src/webenginepartcookiejar.cpp
123

missing space after if, no space after '('

This revision is now accepted and ready to land.Thu, Aug 22, 8:48 PM
This revision was automatically updated to reflect the committed changes.