Chaning default iconSize in systemtray
Needs RevisionPublic

Authored by xshram on Aug 22 2019, 2:36 PM.

Details

Reviewers
ngraham
Summary

A patch for small icons on 4k displays and it doesn't break icons on FullHD display.

Test Plan

Look at icons on KDE on 4k display before patch and after. Restart plasma after patch ofc.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
xshram created this revision.Aug 22 2019, 2:36 PM
xshram created this object with edit policy "Administrators".
Restricted Application added a project: Plasma. · View Herald TranscriptAug 22 2019, 2:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
xshram requested review of this revision.Aug 22 2019, 2:36 PM
xshram changed the edit policy from "Administrators" to "All Users".Aug 22 2019, 2:41 PM
ngraham requested changes to this revision.Aug 22 2019, 2:50 PM
ngraham added a subscriber: ngraham.

The label says:

On high DPI systems those values would be scaled up, depending on the DPI

So I gather that's not working? If not, we should fix that, not work around it by changing the default. FWIW going from 1 to 2 causes the following visual change if you happen to use a double-thickness panel:

This may in fact be desirable, but it's clearly not an intended effect of the patch, and it would need to be done deliberately.

This revision now requires changes to proceed.Aug 22 2019, 2:50 PM
xshram added a comment.EditedAug 22 2019, 2:57 PM

The label says:

On high DPI systems those values would be scaled up, depending on the DPI

So I gather that's not working? If not, we should fix that, not work around it by changing the default. FWIW going from 1 to 2 causes the following visual change if you happen to use a double-thickness panel:

This may in fact be desirable, but it's clearly not an intended effect of the patch, and it would need to be done deliberately.

Yes, scalling doesn't work, attached photo how it looks with default value(1).

Honestly i am a newbee and i didn't find this problem in the code, so i have pushed the way i fixed it locally.

Looks to me that scaling is working just fine for system tray items in your screenshot. It's deliberate that they have that much padding on the top and bottom (at least with the default size settings).

xshram added a comment.EditedAug 22 2019, 3:16 PM

Looks to me that scaling is working just fine for system tray items in your screenshot. It's deliberate that they have that much padding on the top and bottom (at least with the default size settings).

Really? There is a picture, how it looks with value = 2.


What is the point of giving an opportunity to stretch a panel and non giving a opportunity of having icons the same size? But i know my place and if it must be as it is, so be it.

So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to fit in panel", "static icon size", and "n columns". However we don't have a UI that implements this. I would be happy to entertain a patch that added that though.

I can confirm the issue that tray icons are tooooo small on 4k display

So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to fit in panel", "static icon size", and "n columns".

That was i think dated, also i'm pretty sure it has a review that doing it, but it makes things complicated and was reviled.

So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to fit in panel", "static icon size", and "n columns".

That was i think dated, also i'm pretty sure it has a review that doing it, but it makes things complicated and was reviled.

If you can find the patch, maybe we should take another look. This problem isn't going away on its own.