Differential D23338

Use baseFactory for K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL
AbandonedPublic
Actions

Authored by adridg on Aug 22 2019, 10:02 AM.

Details

Reviewers
None
Summary

The existing macro always inherits from KPluginFactory -- making
it hard to use when sub-classing KPluginFactory in order to extend it.
The parameter baseFactory to the macro isn't used.

Use baseFactory as the base class for the plugin.

BUG #410851

Test Plan

This is a tough one. Who knows what kind of junk people have put
into baseFactory, since it's not used.

Diff Detail

Repository
R244 KCoreAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15451
Build 15469: arc lint + arc unit
adridg created this revision.Aug 22 2019, 10:02 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 22 2019, 10:02 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
adridg requested review of this revision.Aug 22 2019, 10:02 AM
adridg abandoned this revision.May 31 2020, 2:34 PM

Re-filed on invent

Revision Contents
Changeset List

PathPackages
Msrc/lib/plugin/kpluginfactory.h (2 lines)

Diff 64280

View Options

src/lib/plugin/kpluginfactory.h

Loading...