Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses
ClosedPublic

Authored by meven on Aug 22 2019, 9:16 AM.

Details

Summary

BUG: 328664

The current behavior to change password is quite unfriendly to say the least.
Clicking in a line field to open a dialog is not logical.
Replace this with a much simpler button leading to the dialog.

Test Plan

Compile
kcmshell5 user_manager
Tried changing your password
Tried adding a user

Before:

After:

Diff Detail

Repository
R128 User Manager
Branch
arcpatch-D23337
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15447
Build 15465: arc lint + arc unit
meven created this revision.Aug 22 2019, 9:16 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 22 2019, 9:16 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Aug 22 2019, 9:16 AM
meven edited the test plan for this revision. (Show Details)Aug 22 2019, 9:17 AM
meven added a reviewer: ngraham.
davidedmundson accepted this revision.Aug 22 2019, 9:19 AM
This revision is now accepted and ready to land.Aug 22 2019, 9:19 AM
meven added a comment.Aug 22 2019, 9:21 AM

This is not yet "great" but makes things more usable.

GB_2 added a reviewer: VDG.Aug 22 2019, 9:29 AM
GB_2 added a project: VDG.
GB_2 added a subscriber: GB_2.
GB_2 added inline comments.
src/account.ui
227

Add the icon document-edit

meven updated this revision to Diff 64275.Aug 22 2019, 9:32 AM

Add icon document-edit

meven edited the test plan for this revision. (Show Details)Aug 22 2019, 9:33 AM
GB_2 accepted this revision.Aug 22 2019, 9:33 AM
meven marked an inline comment as done.Aug 22 2019, 9:33 AM
meven updated this revision to Diff 64276.Aug 22 2019, 9:41 AM

Add a const before a for

meven updated this revision to Diff 64278.Aug 22 2019, 9:48 AM

Replace Q_FOREACH by for

meven updated this revision to Diff 64279.Aug 22 2019, 9:50 AM

Fix tab order

GB_2 edited the summary of this revision. (Show Details)Aug 22 2019, 10:26 AM

The text "change password" is not accurate when you're setting up a new user. For that case, it should say "set password". But the new user creation process is really weird and needs to be redone anyway, so maybe that's the better approach.

Speaking of which, IIRC @nicolasfella was redoing this KCM from scratch with QML. How's that going, Nico?

meven updated this revision to Diff 64402.Aug 23 2019, 9:06 AM

Change the change password button text to Set Password for new users

meven added a comment.Aug 23 2019, 9:08 AM

The text "change password" is not accurate when you're setting up a new user. For that case, it should say "set password". But the new user creation process is really weird and needs to be redone anyway, so maybe that's the better approach.

The "change password" is now set to "set password" for the new user form.

Speaking of which, IIRC @nicolasfella was redoing this KCM from scratch with QML. How's that going, Nico?

Since this code is close to ready and if this new QML KCM is not guaranteed to land before 5.17 we might as well land this in the meantime.

ngraham accepted this revision.Aug 23 2019, 12:16 PM

Shipit!

This revision was automatically updated to reflect the committed changes.