Differential D23333

KDirOperator: Only enable "Create New" menu if the selected item is a directory
ClosedPublic
Actions

Authored by daandemeyer on Aug 22 2019, 8:12 AM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R241:2e9cae63d141: KDirOperator: Only enable "Create New" menu if the selected item is a directory
Summary

Currently, when right-clicking a file in KDirOperator, the "Create New" menu is available and can be used. However, when creating any new directory or file, the operation fails since we're trying to create a directory or file under a file.

This patch modifies KDirOperator to only enable the "Create New" menu when the selected item is a directory.

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
daandemeyer created this revision.Aug 22 2019, 8:12 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 22 2019, 8:12 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
daandemeyer requested review of this revision.Aug 22 2019, 8:12 AM
ngraham accepted this revision.Aug 22 2019, 5:06 PM
ngraham added a subscriber: ngraham.

Do you need someone to commit this for you? If so, can you please provide an email address?

This revision is now accepted and ready to land.Aug 22 2019, 5:06 PM
daandemeyer added a comment.Aug 22 2019, 5:30 PM

Email: daan.j.demeyer@gmail.com (added to my profile as well)

Closed by commit R241:2e9cae63d141: KDirOperator: Only enable "Create New" menu if the selected item is a directory (authored by daandemeyer, committed by ngraham). · Explain WhyAug 22 2019, 6:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filewidgets/kdiroperator.cpp (2 lines)

Diff 64269

View Options

src/filewidgets/kdiroperator.cpp

Loading...