Exclude other desktop file from AppStream metadata generation
ClosedPublic

Authored by ngraham on Aug 21 2019, 7:02 PM.

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Aug 21 2019, 7:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 21 2019, 7:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 21 2019, 7:02 PM
mak added a comment.Aug 21 2019, 7:15 PM

Effect is kdesystemsettings.desktop not being shown in any software center.
LGTM

In D23328#516191, @mak wrote:

Effect is kdesystemsettings.desktop not being shown in any software center.
LGTM

Thanks! How are you testing this?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 21 2019, 7:24 PM
This revision was automatically updated to reflect the committed changes.
mak added a comment.Aug 21 2019, 7:28 PM

I didn't test this, but I wrote the code which will handle this and it works in other cases ;-)
My comment was to confirm that the commit does indeed what you intend it to do, according to the spec and code.