Differential D23321

Indicate appsteam the ps desktop file isn't a separate application
ClosedPublic
Actions

Authored by apol on Aug 21 2019, 3:01 PM.

Details

Reviewers
kossebau
ngraham
Commits
R32:12bf83b0abd0: Indicate appsteam the ps desktop file isn't a separate application
Summary

BUG: 410687

Diff Detail

Repository
R32 KDevelop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15415
Build 15433: arc lint + arc unit
apol created this revision.Aug 21 2019, 3:01 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 21 2019, 3:01 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
apol requested review of this revision.Aug 21 2019, 3:01 PM
ngraham accepted this revision.Aug 21 2019, 3:02 PM
ngraham added a subscriber: mak.

Yep, according to @mak, this should work.

This revision is now accepted and ready to land.Aug 21 2019, 3:02 PM
ngraham edited the summary of this revision. (Show Details)Aug 21 2019, 3:02 PM
kossebau requested changes to this revision.Aug 21 2019, 3:05 PM

From what I understood, this is effectless, as _ps is referenced by <launchable>. We need to check with @mak here.

This revision now requires changes to proceed.Aug 21 2019, 3:05 PM
apol updated this revision to Diff 64220.Aug 21 2019, 3:09 PM

Don't mention the ps desktop file as the executable

kossebau added a comment.EditedAug 21 2019, 3:11 PM
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

It was mentioned on purpose though, cmp. commit message of ab22ca659cf337fc1de01d69b0ced949156f01e5 (result of discussion on KDevelop with @flherne )

apol updated this revision to Diff 64223.Aug 21 2019, 3:23 PM

BUG: 410687

apol added a comment.Aug 21 2019, 3:25 PM
In D23321#516025, @kossebau wrote:
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

It was mentioned on purpose though, cmp. commit message of ab22ca659cf337fc1de01d69b0ced949156f01e5 (result of discussion on KDevelop with @flherne )

The reason there is weird. When you press "launch" on the software center you expect to get the IDE, not an empty list of sessions.

kossebau added a comment.Aug 21 2019, 3:25 PM
In D23321#516034, @apol wrote:

BUG: 410687

Yes, well aware :) But that bug was reported before the "<launchable>" entry was added. cmp. comment 4

mak added a comment.Aug 21 2019, 6:37 PM

This patch looks like it should work as intended to me :)

kossebau accepted this revision.Aug 22 2019, 2:57 PM
In D23321#516037, @apol wrote:
In D23321#516025, @kossebau wrote:
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

It was mentioned on purpose though, cmp. commit message of ab22ca659cf337fc1de01d69b0ced949156f01e5 (result of discussion on KDevelop with @flherne )

The reason there is weird. When you press "launch" on the software center you expect to get the IDE, not an empty list of sessions.

The reasoning is coming from people who already have kdevelop sessions on their system.

Thinking more about it, possibly more often people will launch kdevelop from the installer after first installation than on updates. And I agree for those new to KDevelop reaching directly the shell window with the welcome screen is the better experience.
If people complain because they want the session chooser dialog, we could still add the _ps desktop file as alternative launcher later :)

To 5.4 branch, please.

This revision is now accepted and ready to land.Aug 22 2019, 2:57 PM

Revision Contents
Changeset List

Diff 64223

View Options

app/org.kde.kdevelop_ps.desktop

Loading...
View Options

org.kde.kdevelop.appdata.xml

Loading...