Add a warning message about needing globally installed theme files
ClosedPublic

Authored by filipf on Aug 20 2019, 8:37 PM.

Details

Summary

Settings sync only works for theme files that are installed globally.

We should add a warning message so users aren't confused when some aspect of the feature doesn't work.

Test Plan

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Aug 20 2019, 8:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 20 2019, 8:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Aug 20 2019, 8:37 PM
filipf edited the test plan for this revision. (Show Details)Aug 20 2019, 8:38 PM
filipf added reviewers: Plasma, davidedmundson, VDG, ngraham.
filipf updated this revision to Diff 64997.Fri, Aug 30, 2:22 PM

Rebase on master (hopefully)

ngraham added inline comments.Fri, Aug 30, 7:13 PM
src/ui/advancedconfig.ui
154

Looks unrelated

171

Looks unrelated

246

Maybe mention the actual path "In the root directory" is both unhelpful and inaccurate if read literally

filipf added inline comments.Sat, Aug 31, 9:57 AM
src/ui/advancedconfig.ui
154
171
246

I would assume it's /usr/share/ but I don't know it that's true for all distros and BSD?

filipf added inline comments.Sat, Aug 31, 10:02 AM
src/ui/advancedconfig.ui
246

/usr/share would just be less inaccurate then anyway, these "theme files" mentioned are all installed in different locations so I'd have to list all of them:

/usr/share/fonts
/usr/share/plasma/desktop-theme
/usr/share/icons

ngraham added inline comments.Sat, Aug 31, 4:22 PM
src/ui/advancedconfig.ui
246

All right, just get rid of "(in the root directory)" then.

filipf updated this revision to Diff 65084.Sat, Aug 31, 10:45 PM
  • remove "in the root directory"
ngraham accepted this revision.Sun, Sep 1, 3:02 AM
This revision is now accepted and ready to land.Sun, Sep 1, 3:02 AM
This revision was automatically updated to reflect the committed changes.