[weather] [envcan] Add additional current condition icon mappings
ClosedPublic
Actions

Authored by spstarr on Aug 20 2019, 7:42 PM.

Details

Reviewers

ngraham
kossebau

Group Reviewers

Plasma

Summary

[weather] [envcan] Add additional current condition icon mappings

Test Plan

Built and tested with changes and see the correct current condition icon shown.

Repository

R120 Plasma Workspace

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Will merge once reviewed.

Current XML shows (until the storm ends)

<condition>Thunderstorm with heavy rainshowers</condition>

Change "rainshowers" to "rain showers" ("rainshower" isn't a word)

This revision now requires changes to proceed.Aug 20 2019, 7:46 PM

Thats the XML however, it is matching 'rainshowers'

Ah ok.

Ideally, this list shouldn't be so long since the XML schema http://dd.weatheroffice.ec.gc.ca/citypage_weather/docs/current_conditions_icon_code_descriptions_e.csv lists them all, except thats not what the XML shows :/ I should ask EC why the discrepancy

spstarr requested review of this revision.Aug 21 2019, 9:32 PM

This revision is now accepted and ready to land.Aug 21 2019, 9:44 PM

Can you push this to the 5.16 branch? No new string for translators, so should be fine to improve for stable.

In D23307#516304, @kossebau wrote:

Can you push this to the 5.16 branch? No new string for translators, so should be fine to improve for stable.

Sure thing, ill do in morning

Merged into master, Plasma/5.16.

			Path	Packages
M			dataengines/weather/ions/data/envcan_i18n.dat (2 lines)
M			dataengines/weather/ions/envcan/ion_envcan.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	64164			Aug 20 2019, 7:41 PM	★	★