[weather] [envcan] Add additional current condition icon mappings
ClosedPublic

Authored by spstarr on Tue, Aug 20, 7:42 PM.

Details

Reviewers
ngraham
kossebau
Group Reviewers
Plasma
Summary

[weather] [envcan] Add additional current condition icon mappings

Test Plan

Built and tested with changes and see the correct current condition icon shown.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
spstarr created this revision.Tue, Aug 20, 7:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Aug 20, 7:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
spstarr requested review of this revision.Tue, Aug 20, 7:42 PM

Will merge once reviewed.

Current XML shows (until the storm ends)

<condition>Thunderstorm with heavy rainshowers</condition>

ngraham requested changes to this revision.Tue, Aug 20, 7:46 PM
ngraham edited reviewers, added: Plasma; removed: Plasma: Workspaces.
ngraham added a subscriber: ngraham.

Change "rainshowers" to "rain showers" ("rainshower" isn't a word)

This revision now requires changes to proceed.Tue, Aug 20, 7:46 PM

Thats the XML however, it is matching 'rainshowers'

ngraham resigned from this revision.Tue, Aug 20, 7:47 PM

Ah ok.

Ideally, this list shouldn't be so long since the XML schema http://dd.weatheroffice.ec.gc.ca/citypage_weather/docs/current_conditions_icon_code_descriptions_e.csv lists them all, except thats not what the XML shows :/ I should ask EC why the discrepancy

spstarr requested review of this revision.Wed, Aug 21, 9:32 PM
ngraham accepted this revision.Wed, Aug 21, 9:44 PM
This revision is now accepted and ready to land.Wed, Aug 21, 9:44 PM
kossebau accepted this revision.Wed, Aug 21, 10:24 PM

Can you push this to the 5.16 branch? No new string for translators, so should be fine to improve for stable.

Can you push this to the 5.16 branch? No new string for translators, so should be fine to improve for stable.

Sure thing, ill do in morning

spstarr closed this revision.Thu, Aug 22, 3:50 AM

Merged into master, Plasma/5.16.