Differential D23303

gcclikecompiler: properly resolve include paths containing symbolic links
ClosedPublic
Actions

Authored by akellermann on Aug 20 2019, 7:23 PM.

Details

Reviewers
mwolff
Summary

Make sure include paths containing symbolic links are canonicalized - and thereby properly resolved - before wrapping them in a Path object. This is necessary, as class Path is not properly handling symbolic links.
A detailed description of the faulty behavior and the circumstances that can provoke it can be found in bug https://bugs.kde.org/show_bug.cgi?id=405221.

Diff Detail

Repository
R32 KDevelop
Lint
Lint Skipped
Unit
Unit Tests Skipped
akellermann created this revision.Aug 20 2019, 7:23 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 20 2019, 7:23 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
akellermann requested review of this revision.Aug 20 2019, 7:23 PM
mwolff added a comment.Sep 20 2019, 3:51 AM

I'll commit this using QFileInfo instead of going through QDir.

thanks!

mwolff accepted this revision.Sep 20 2019, 4:07 AM

done now, thanks a lot!

This revision is now accepted and ready to land.Sep 20 2019, 4:07 AM
mwolff closed this revision.Sep 20 2019, 4:07 AM

Revision Contents
Changeset List

Diff 64154

View Options

plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.cpp

Loading...